Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 960
TitelFeature/ll php stan level 3
Beschreibung
Statusmerged
Created at 2024-04-25T15:06:51.971Z
Updated at 2024-05-07T05:38:26.491Z
Source branchfeature/LL-php-stan-level-3
Target branchrelease/4.7.0
AuthorGregor Gabriel
AssigneeSascha Immig

Discussion notes

added 1 commit
  • 4181e782 - switched to php-stan-level-4 and fixed first real error in AdditionalServiceService
Compare with previous version
Gregor Gabriel 2024-04-25T15:32:35.411Z
added 1 commit
  • 136ed83c - litle corrections for php-stan-level-4 compatibility
Compare with previous version
Gregor Gabriel 2024-04-25T16:16:37.227Z
added 1 commit
  • c7e0d59f - adapted expiring system reminders, so that training assignments without user are not handled
Compare with previous version
Gregor Gabriel 2024-04-25T16:17:59.870Z
added 1 commit
  • 59363341 - + fixed some logic probelems where float progress_score was === compared with integers
Compare with previous version
Gregor Gabriel 2024-04-25T17:03:55.194Z
added 1 commit
  • 0796ff8e - + several important small bugfixes identified by php-stan-level-4
Compare with previous version
Gregor Gabriel 2024-04-26T09:34:32.793Z
added 1 commit
  • e7f79f68 - fixed some problems for php-stan-level-5 (79 problems left)
Compare with previous version
Gregor Gabriel 2024-04-26T10:07:26.199Z
added 1 commit
  • 20c1b151 - added more explicite variable type declatation for BelongsToMany relations
Compare with previous version
Gregor Gabriel 2024-04-26T11:09:35.726Z
added 1 commit
  • 264b7866 - added extended type declaration for BelongsTo relations
Compare with previous version
Gregor Gabriel 2024-04-26T11:49:20.155Z
added 1 commit
  • 60dfb1d7 - extended type declarations for HasMany relations
Compare with previous version
Gregor Gabriel 2024-04-26T12:13:16.993Z
added 1 commit
  • 94cc76e7 - extended type declarations for HasOne, HasOneThrough and HasManyThrough relations
Compare with previous version
Gregor Gabriel 2024-04-26T12:27:48.600Z
added 1 commit
  • 36028ae8 - little php-stan-level-5 fixes
Compare with previous version
Gregor Gabriel 2024-04-26T12:43:46.337Z
added 1 commit
  • f171c63c - + reduced php-stan-level-5 errors to 45
Compare with previous version
Gregor Gabriel 2024-04-29T12:17:12.464Z
added 1 commit
  • 765794b4 - removed unused variable
Compare with previous version
Gregor Gabriel 2024-04-29T12:46:35.165Z
added 1 commit
  • 6bd18b69 - + reduced errors to 7
Compare with previous version
Gregor Gabriel 2024-04-29T14:12:19.275Z
added 57 commits
  • 6bd18b69...5cfb5a4d - 56 commits from branch develop
  • 87d96103 - Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into…
Compare with previous version
Gregor Gabriel 2024-05-06T15:03:08.028Z
added 1 commit
  • c238248f - fixed some php-stan-level-4 errors (6 left where 3 have to be discussed)
Compare with previous version
Gregor Gabriel 2024-05-06T15:24:27.018Z
changed target branch from `develop` to `release/4.7.0` Sascha Immig 2024-05-06T16:12:32.488Z
merged Sascha Immig 2024-05-07T05:38:26.557Z
mentioned in commit 0400c2c2f7605aed884b826aeaa55360bf8b02c9 Sascha Immig 2024-05-07T05:38:26.608Z

Merge Commits

Title Id Author Created at Message
+ several important small bugfixes identified by php-stan-level-4 0796ff8effc3c889bd57ff103d4297e1503c4d19 TUV\gabrielg 2024-04-26T09:34:21.000Z + several important small bugfixes identified by php-stan-level-4 --- 8 problems left ---
litle corrections for php-stan-level-4 compatibility 136ed83c47fc9628c462e72d654df0dd9010a312 TUV\gabrielg 2024-04-25T16:16:26.000Z litle corrections for php-stan-level-4 compatibility
added more explicite variable type declatation for BelongsToMany relations 20c1b1515bb6698b470cac369bb2ab1dfd7a4d8c TUV\gabrielg 2024-04-26T11:09:24.000Z added more explicite variable type declatation for BelongsToMany relations
provided separate class for anonymous object to help php-stan to analyse the code 25020d7bb918958f2abc07f84ab5a51c561ad9de TUV\gabrielg 2024-04-25T12:56:31.000Z provided separate class for anonymous object to help php-stan to analyse the code
added extended type declaration for BelongsTo relations 264b78667b9feff3bce866d2c6a8a2760e3085c4 TUV\gabrielg 2024-04-26T11:49:05.000Z added extended type declaration for BelongsTo relations
little php-stan-level-5 fixes 36028ae85bc2bc656b31a2048f43d79034a10982 TUV\gabrielg 2024-04-26T12:43:35.000Z little php-stan-level-5 fixes
switched to php-stan-level-4 and fixed first real error in AdditionalServiceService 4181e782734d900a76fcfd0058f1c8948f48be21 TUV\gabrielg 2024-04-25T15:32:26.000Z switched to php-stan-level-4 and fixed first real error in AdditionalServiceService
run php-cs-fixer 590aa287463509a7c188661cf36d91100aa8a689 TUV\gabrielg 2024-04-25T08:38:31.000Z run php-cs-fixer
+ fixed some logic probelems where float progress_score was === compared with integers 59363341fd63c30f1f83e7683df8f4cda6b54eb3 TUV\gabrielg 2024-04-25T17:03:47.000Z + fixed some logic probelems where float progress_score was === compared with integers + fixed some not exactly declared types + reduced to 61 php-stan-level-4 problems
extended type declarations for HasMany relations 60dfb1d7daef75534389c3f86c497cb6362ca9c4 TUV\gabrielg 2024-04-26T12:13:07.000Z extended type declarations for HasMany relations
+ reduced errors to 7 6bd18b692dd5522be408d4672e4ab571fae0bdb4 TUV\gabrielg 2024-04-29T14:12:05.000Z + reduced errors to 7 + fixed training view for superadmins, when Training is not available without subscription + added comment about a variable, that seems unused, but that is used in a trait
removed unused variable 765794b4b561fbfb692790c056f9b24124ee2b2c TUV\gabrielg 2024-04-29T12:46:19.000Z removed unused variable
reduced php-stan-level-3 problems to 21 7a377e6814caafd6071a1500fae17fd75569b563 TUV\gabrielg 2024-04-25T12:07:07.000Z reduced php-stan-level-3 problems to 21
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into… 87d96103edc52513dc4efa70a41677249858f511 TUV\gabrielg 2024-05-06T15:02:53.000Z Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/LL-php-stan-level-3 # Conflicts: # app/Console/Commands/SendExpiredUnprocessedTrainingMails.php # app/Models/TrainingAssignment.php # app/Models/TrainingReminder.php # app/Notifications/ExpiredUnprocessedAssignments.php # app/Notifications/ExpiringUnprocessedOrdersFirst.php # app/Notifications/ExpiringUnprocessedOrdersLast.php # app/Repositories/Admin/DistributionPartnerRepository.php # app/Services/SendExpiringUnprocessedOrderMailsService.php
extended type declarations for HasOne, HasOneThrough and HasManyThrough relations 94cc76e740bd74fc13e161a352247334600ff29e TUV\gabrielg 2024-04-26T12:27:38.000Z extended type declarations for HasOne, HasOneThrough and HasManyThrough relations
fixed some php-stan-level-4 errors (6 left where 3 have to be discussed) c238248fa4582f844d93a4289791467fd1669c53 TUV\gabrielg 2024-05-06T15:24:10.000Z fixed some php-stan-level-4 errors (6 left where 3 have to be discussed)
adapted expiring system reminders, so that training assignments without user are not handled c7e0d59f2e9707db8b4c9518514f6150f4655d66 TUV\gabrielg 2024-04-25T16:17:49.000Z adapted expiring system reminders, so that training assignments without user are not handled
reduced php-stan-level-3 problems to 5 d1700fc731a3349d06c62dfdbad2ea9da15c338f TUV\gabrielg 2024-04-25T14:59:01.000Z reduced php-stan-level-3 problems to 5
fixed some problems for php-stan-level-5 (79 problems left) e7f79f68d7c174117468fcb6999baee9903e37a7 TUV\gabrielg 2024-04-26T10:07:16.000Z fixed some problems for php-stan-level-5 (79 problems left)
+ reduced php-stan-level-5 errors to 45 f171c63c6425c2fb5ad1270efc2225f95a88f47b TUV\gabrielg 2024-04-29T12:16:56.000Z + reduced php-stan-level-5 errors to 45 + switched back to php-stan-level-4 where we have 9 errors, where some can be fixed easily