merge request id	939
Titel	LL-1607-training-reminders-interval-delivery && LL-1715-fix-error-when-saving…
Beschreibung	LL-1607-training-reminders-interval-delivery && LL-1715-fix-error-when-saving training-reminders-type-date Add colums interval and interval_delivery_at to training-reminders table define interval is only available for reminders with type date allowed interval values under 7 days and over 180 days expired reminders are updated via cron job set trigger for date with trigger_date
Status	merged
Created at	2024-03-01T13:32:18.189Z
Updated at	2024-03-06T14:03:12.057Z
Source branch	feature/LL-1607-training-reminders-interval-delivery
Target branch	develop
Author	Markus Gerlach
Assignee	Sascha Immig

Discussion notes

könnte als Start-Date nicht `interval_delivery_at` übergeben werden? das entspricht doch bereits dem Trigger plus Interval..?	Sascha Immig	2024-03-05T11:11:22.380Z
Verstehe die Übergabe vom `TYPE_DATE_INTERVAL_MAX` als `$endDate` hier ebenfalls nicht. Zum einen könnte das fest in der Funktion `getNextDateOfPeriod` hinterlegt sein und nicht übergeben werden (sehe nicht, dass das flexibel sein muss), was eine Parameter in der Signatur spart. Das 2. ist: ein optionales Parameter (`$interval`) vor einem verpflichtenden Parameter (`$endDate`) ist absolut nicht sinnvoll.	Sascha Immig	2024-03-05T11:15:11.670Z
added 1 commit f0190243 - UI fixes: overhauled markup and corected styles for smaller screens. Compare with previous version	Sascha Immig	2024-03-05T13:55:25.088Z
changed this line in version 3 of the diff	Gregor Gabriel	2024-03-06T12:18:58.374Z
changed this line in version 3 of the diff	Gregor Gabriel	2024-03-06T12:18:58.700Z
resolved all discussions	Gregor Gabriel	2024-03-06T12:18:58.759Z
added 1 commit 97f04f05 - slightly reworked and optimized code Compare with previous version	Gregor Gabriel	2024-03-06T12:18:58.987Z
added 3 commits 625e0c0b - moved translation "days" from subscriptions to base 714b5e79 - optimized table layout 76e81441 - code cosmetic Compare with previous version	Sascha Immig	2024-03-06T13:56:17.721Z
enabled an automatic merge when the pipeline for 76e8144129bcb9aabcee083fb7f7b9439323a3b4 succeeds	Sascha Immig	2024-03-06T13:57:44.627Z
merged	Sascha Immig	2024-03-06T14:03:12.110Z
mentioned in commit 9ff1388884316298da702ea7e1d1d3f719c51408	Sascha Immig	2024-03-06T14:03:12.226Z

Merge Commits

Title	Id	Author	Created at	Message
LL-1607-training-reminders-interval-delivery && LL-1715-fix-error-when-saving…	32f5b9f7df7253a5f8715c0ac5787c217937d479	gerlachm	2024-03-01T13:14:44.000Z	LL-1607-training-reminders-interval-delivery && LL-1715-fix-error-when-saving training-reminders-type-date Add colums interval and interval_delivery_at to training-reminders table define interval is only available for reminders with type date allowed interval values under 7 days and over 180 days expired reminders are updated via cron job set trigger for date with trigger_date
moved translation "days" from subscriptions to base	625e0c0b029bce49cf41de461f3d19192781ca9c	TUV\immigs	2024-03-06T13:55:01.000Z	moved translation "days" from subscriptions to base
optimized table layout	714b5e7998f54f2aac97427fb5bcff6d214ff099	TUV\immigs	2024-03-06T13:55:59.000Z	optimized table layout
code cosmetic	76e8144129bcb9aabcee083fb7f7b9439323a3b4	TUV\immigs	2024-03-06T13:56:10.000Z	code cosmetic
slightly reworked and optimized code	97f04f051d3b32ce7c165be246123764f8e5d1d7	TUV\gabrielg	2024-03-06T12:18:50.000Z	slightly reworked and optimized code
UI fixes: overhauled markup and corected styles for smaller screens.	f0190243857ea0f696fa47f2eb5ab530a0465bd4	TUV\immigs	2024-03-05T10:54:50.000Z	UI fixes: overhauled markup and corected styles for smaller screens.