merge request id	926
Titel	LL-1672-trainings-that-cannot-be-booked-can-be-assigned-in-classroomtraining
Beschreibung	remove trainings that cannot be booked inn classroom edit and create form select options employee report training selection remains with non-bookable trainings options
Status	merged
Created at	2024-01-29T11:04:05.948Z
Updated at	2024-02-08T15:48:34.341Z
Source branch	feature/LL-1672-trainings-that-cannot-be-booked-can-be-assigned-in-classroomtraining
Target branch	develop
Author	Markus Gerlach
Assignee	Gregor Gabriel

Discussion notes

`ignoreBookable` ist nicht die Beste Wahl für den Variablen-Namen: Im ersten Moment ist nicht intuitiv, obder Flag ignoriert wird oder eine Buchung mit dem Flag. besser `$onlyBookable` -> `true: trainings that cannot be booked will not be shown` Default-Wert wäre dann false, statt true.	Sascha Immig	2024-01-29T14:03:25.215Z
s.o.	Sascha Immig	2024-01-29T14:03:45.726Z
Generell stellen sich mir 2 Fragen: Brauchen wir sowohl `allForOptionsFromCatalogWithNull` als auch `allForOptionsFromCatalog` mit übergabe-Parameter? Wäre statt `allForOptionsFromCatalogWithNull` mit Param nicht eine eigene, sprechende Funktion sinnvoll - z.B. `booableForOptions` (oder `bookableForOptionsFromCatalogWithNull`, wenn es sein muss)?	Sascha Immig	2024-01-29T14:06:30.006Z
assigned to @gabrielg	Sascha Immig	2024-02-07T10:02:24.415Z
changed this line in version 2 of the diff	Gregor Gabriel	2024-02-08T15:22:40.538Z
changed this line in version 2 of the diff	Gregor Gabriel	2024-02-08T15:22:41.181Z
added 1 commit 6a603334 - slightly reworked code Compare with previous version	Gregor Gabriel	2024-02-08T15:22:41.349Z
added 1 commit 997b2da5 - added optional parameter $withNullOption to method and thus throw away one method Compare with previous version	Gregor Gabriel	2024-02-08T15:41:25.252Z
Ja - habe einen zweiten Parametre hinzugefügt, so dass die eine Methode entfallen ist	Gregor Gabriel	2024-02-08T15:42:37.619Z
resolved all discussions	Gregor Gabriel	2024-02-08T15:42:38.359Z
enabled an automatic merge when the pipeline for 997b2da52b970ab42d9ac0ceb2a29fbbb0f52811 succeeds	Gregor Gabriel	2024-02-08T15:42:42.350Z
merged	Gregor Gabriel	2024-02-08T15:48:34.424Z
mentioned in commit d1680a34ea04f58d6a0e88ade0a596e00a76a8a5	Gregor Gabriel	2024-02-08T15:48:34.685Z

Merge Commits

Title	Id	Author	Created at	Message
slightly reworked code	6a603334b3e36687bc288b718b9bd9a8c5aa0053	TUV\gabrielg	2024-02-08T15:22:31.000Z	slightly reworked code
added optional parameter $withNullOption to method and thus throw away one method	997b2da52b970ab42d9ac0ceb2a29fbbb0f52811	TUV\gabrielg	2024-02-08T15:41:21.000Z	added optional parameter $withNullOption to method and thus throw away one method
LL-1672-trainings-that-cannot-be-booked-can-be-assigned-in-classroomtraining	d7f25aa0f285518053eb1352dd0672c840fb8a1d	gerlachm	2024-01-29T10:42:40.000Z	LL-1672-trainings-that-cannot-be-booked-can-be-assigned-in-classroomtraining remove trainings that cannot be booked inn classroom edit and create form select options employee report training selection remains with non-bookable trainings options