Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 917
TitelFeature/ll 1679 internal identifier for pages
Beschreibung
Statusmerged
Created at 2023-12-22T15:13:43.430Z
Updated at 2024-01-15T11:05:50.968Z
Source branchfeature/LL-1679-internal-identifier-for-pages
Target branchdevelop
AuthorMarkus Gerlach
AssigneeSascha Immig

Discussion notes

added 4 commits
  • d9927bd1 - fixed migration: default should be null, not "". Also prefilled correct page.
  • de8f5fcb - Optimized translations
  • 623e5e77 - fixed validation to allow to revoke an indetifier
  • 9def185c - simplified aproach: it is sufficent to not allow duplication of identifiers; we…
Compare with previous version
Sascha Immig 2024-01-15T10:00:14.654Z
added 1 commit
  • 7873d48b - clean up
Compare with previous version
Sascha Immig 2024-01-15T10:13:26.282Z
added 3 commits
  • deff77f3 - Bei getNextPossibleEndAttribute wurde date verwendet. Im Test wird über Carbon…
  • 3855a425 - Check des Additional ServiceTest
  • 63c57f47 - Im Test werden nun subscriptions mit einem festen Beginn-datum angelegt. Durch…
Compare with previous version
Sascha Immig 2024-01-15T10:19:17.816Z
added 1 commit
  • a1ef4da2 - completed clean up
Compare with previous version
Sascha Immig 2024-01-15T10:57:10.260Z
enabled an automatic merge when the pipeline for a1ef4da21767f4e78b2ea05ce1d665c22782e55f succeeds Sascha Immig 2024-01-15T11:03:09.815Z
merged Sascha Immig 2024-01-15T11:05:51.091Z
mentioned in commit fa111d99ef65ce06223045a0dd251dcb8dbe0237 Sascha Immig 2024-01-15T11:05:51.227Z

Merge Commits

Title Id Author Created at Message
Check des Additional ServiceTest 3855a425afa50c13f9085c65b86a8af6c5dfd6dd Richard Klings 2024-01-15T10:18:37.000Z Check des Additional ServiceTest (cherry picked from commit 286c624a9053be70bcf122d6307c6025d545bc12)
fixed validation to allow to revoke an indetifier 623e5e7725e386ef916f3e0070f1e09a6d3d6a4d TUV\immigs 2024-01-12T14:42:42.000Z fixed validation to allow to revoke an indetifier
Im Test werden nun subscriptions mit einem festen Beginn-datum angelegt. Durch… 63c57f47ed8667743a81184bf7b917b4fde342d4 Richard Klings 2024-01-15T10:18:57.000Z Im Test werden nun subscriptions mit einem festen Beginn-datum angelegt. Durch die Varianten aus der Factory liefen die Tests nicht immer durch. Durch das "date" wurde das bisher verdeckt. Ein copy eingebaut, um nicht das Original zu verändern. (cherry picked from commit cea85e46b4cfc46fee3fb3b72f657c454029679e)
clean up 7873d48b3cbca8fb5c3ff3be010cab8fabf4d96d TUV\immigs 2024-01-15T10:12:42.000Z clean up
LL-1679-internal-identifier-for-pages 88b08c81ee7833338e6545e9e4a99e3d92328e04 gerlachm 2023-12-22T14:09:43.000Z LL-1679-internal-identifier-for-pages Added new optional field Identifier An identifier is entered using a script for the legal pages (terms and conditions, data protection, legal notice)
simplified aproach: it is sufficent to not allow duplication of identifiers; we… 9def185cfd86087be1620fca9f42d447bff9d68e TUV\immigs 2024-01-15T09:59:55.000Z simplified aproach: it is sufficent to not allow duplication of identifiers; we do not need to count and alternate. Also: client slugs are irrelevant here. Therefor replaced the vue component with simple input: the interaction with title and additional checks are not needed.
completed clean up a1ef4da21767f4e78b2ea05ce1d665c22782e55f TUV\immigs 2024-01-15T10:56:52.000Z completed clean up
fixed migration: default should be null, not "". Also prefilled correct page. d9927bd1681c75ed870720bfac7cdfcc078d1a58 TUV\immigs 2024-01-12T13:58:14.000Z fixed migration: default should be null, not "". Also prefilled correct page.
Optimized translations de8f5fcb41e3b7c0946ba4459988030e4265d522 TUV\immigs 2024-01-12T14:12:18.000Z Optimized translations
Bei getNextPossibleEndAttribute wurde date verwendet. Im Test wird über Carbon… deff77f3ee7e4fc7103a4b6a0c2d8c077d2d851b Richard Klings 2024-01-15T10:17:58.000Z Bei getNextPossibleEndAttribute wurde date verwendet. Im Test wird über Carbon eine andere Zeit gesetzt, was dann 2024 statt 2023 lieferte und den Test fehlschlagen lies (cherry picked from commit 106b448268a24c3ddcb0c0ec1b8dd71dffa9752e)
fix tests e1650ca1491eebdc08603569865b828249a15937 gerlachm 2023-12-22T15:01:31.000Z fix tests