merge request id	894
Titel	Feature/code review
Beschreibung	*A)* der Code unter app/ wurde komplett durchgearbeitet und Fehler, die die IDE gemeledet hat wurden beinahe ausnahmslos beseitigt. Nicht beseitigt wurden Meldungen über die *nicht Verwendung von Funtionen* (=unused element), *Code-Duplikate* und *Potentially polimorphyc call* . *B)* Der Code wurde danach mit PHP-Stan analysiert und beinahe alle Probleme beseitigt. *Wichtig* ist hier, dass *composer analyse app/Model/* keine Fehler liefert, aber *composer analyse app/* meldet, dass in einigen Model-Klassen undefinierte Probleme existieren (Class self was not found while trying to analyse it - discovering symbols is probably not configured properly.)
Status	merged
Created at	2023-10-27T07:02:16.101Z
Updated at	2023-11-07T13:40:33.417Z
Source branch	feature/code-review
Target branch	develop
Author	Gregor Gabriel
Assignee	Sascha Immig

Discussion notes

added 1 commit f4c0d2de - added types to some closures Compare with previous version	Gregor Gabriel	2023-10-27T07:03:15.565Z
added 1 commit fa48438c - added missing exceptions Compare with previous version	Gregor Gabriel	2023-10-27T07:16:50.062Z
added 11 commits fa48438c...0e13f8f8 - 10 commits from branch develop b686ae77 - Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/code-review Compare with previous version	Gregor Gabriel	2023-11-06T10:53:12.898Z
merged	Sascha Immig	2023-11-07T13:40:33.455Z

Merge Commits

Title	Id	Author	Created at	Message
fixe zu den fixes	050c61c98e6b2ce34041c1b5e25316df41ece3bc	TUV\gabrielg	2023-10-24T06:26:50.000Z	fixe zu den fixes
reduced php-stan errors to 39	14970000e0f8b5d1b1dee6b5090c36b200ab38a0	TUV\gabrielg	2023-10-24T17:21:03.000Z	reduced php-stan errors to 39
reworked none admin controllers	250f7fdad61d3f1b27484dfb89de19f708b46a54	TUV\gabrielg	2023-10-24T10:52:18.000Z	reworked none admin controllers
fixed further php-stan problems	2ce6917c1b2c06d1cab1e58c6b891f0cc8e719c8	TUV\gabrielg	2023-10-25T08:45:50.000Z	fixed further php-stan problems
reworked middlewares, requests, resources and routes	3167f45a68f036e64f2bfeaf10501e6f2eec6d48	TUV\gabrielg	2023-10-23T17:02:25.000Z	reworked middlewares, requests, resources and routes
reworked code to comply with php-stan - 39 problems left	3f6fcbc60509066389b3bc36d5c3eca5496084af	TUV\gabrielg	2023-10-24T17:11:14.000Z	reworked code to comply with php-stan - 39 problems left
+ applied php-cs-fixer	58336d92937f8fb42e9e1268639290a73f12afc9	TUV\gabrielg	2023-10-25T06:53:15.000Z	+ applied php-cs-fixer + resolved further php-stan-errors
reworked seeders, factories, scopes, some models and services	7161a88cb36b8f42107c76e51ef80db99b34a710	TUV\gabrielg	2023-10-23T14:43:13.000Z	reworked seeders, factories, scopes, some models and services
fixed some php-stan errors	844195246c752126f2eb36807ca9338ec2351592	TUV\gabrielg	2023-10-24T15:47:31.000Z	fixed some php-stan errors
reworked models after calling php-stan exclusively on model folder	87394849b4858f5b0efc11c8b4777b23ff8df30d	TUV\gabrielg	2023-10-26T08:26:30.000Z	reworked models after calling php-stan exclusively on model folder
resolved some php-stan problems together with Sascha	9d109f1efc79bee5b0f24f72dff0c5438a398850	TUV\gabrielg	2023-10-25T08:14:02.000Z	resolved some php-stan problems together with Sascha
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/code-review	b686ae77a93cd7319711defa7afcee2819079af9	TUV\gabrielg	2023-11-06T10:53:01.000Z	Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/code-review # Conflicts: # app/Console/Commands/ExportObfuscatedDatabase.php # app/Console/Commands/ExportObfuscatedDatabaseLight.php
reworked kernel file	b9d13d5cbceb10947d1a295f2a341b19a0020081	TUV\gabrielg	2023-10-23T16:06:54.000Z	reworked kernel file
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/code-review	bc0487ba906399f0191141e667f0ee96a9229075	TUV\gabrielg	2023-10-23T16:04:05.000Z	Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/code-review
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/code-review	c26734807ffb763c45ae4166ed0d422fdc493040	TUV\gabrielg	2023-10-26T11:39:19.000Z	Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/code-review
reworked admin controllers	d5c59a94e16b65df8f65b9857da48b842a24cfc7	TUV\gabrielg	2023-10-24T15:09:36.000Z	reworked admin controllers
fixed rest of fixable model problems for php-stan	e3154bb8b91d71def8c15566b29533ba706f7d79	TUV\gabrielg	2023-10-26T11:38:43.000Z	fixed rest of fixable model problems for php-stan Signed-off-by: TUV\gabrielg <gregor.gabriel@de.tuv.com>
reworked models	e5456ba52b156af1ac98438f8b88744a0d5f84c0	TUV\gabrielg	2023-10-23T16:03:24.000Z	reworked models
added types to some closures	f4c0d2de2a3fbf0e2a40a86632b31c9ef56dfdb1	TUV\gabrielg	2023-10-27T07:01:59.000Z	added types to some closures
added missing exceptions	fa48438c5abee0bdaf58157f1386753483856b95	TUV\gabrielg	2023-10-27T07:16:41.000Z	added missing exceptions