Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 804
TitelFeature/ll 1498 base account information notification on mail template
BeschreibungCode von LL-LL-1498 (Mail-Templates reaktivieren) abgezweigt und LL-1467 reinintegriert (neue Notification AccountInformation) Dann die neue Notification AccountInformation auf ein Mail-Template umgestellt
Statusmerged
Created at 2023-05-25T14:31:35.264Z
Updated at 2023-06-28T19:05:05.256Z
Source branchfeature/LL-1498-base-account-information-notification-on-mail-template
Target branchdevelop
AuthorGregor Gabriel
AssigneeSascha Immig

Discussion notes

closed Sascha Immig 2023-06-01T15:31:10.738Z
reopened Sascha Immig 2023-06-01T15:31:14.676Z
1) Das alte, statische Template aus LL-1467 ist noch im Zweig vorhanden. Das sollte bereinigt werden. 2) Aktuell befinden sich mit LL-1498 und LL-1496 zwei unterschiedliche Branches in Review, die einen Reload des Seeders triggern - in zwei unterschiedlichen Migrationen. Im Hinblick auf den späteren, gemergten Zustand ist das ggf. nicht so optimal. Hier wäre noch Rücksprache-Bedarf. Sascha Immig 2023-06-01T15:31:32.966Z
Inhaltlich: Beim Test ist mir klar geworden, dass die Anforderung von Kundenseite gar nicht umsetzbar ist. Gewünscht war, die bestehenden Zugangsdaten zu senden, die wir ja nicht haben. Bedingt dadurch, dass wir das PW neu generieren müssen ergeben sich 2 Umstände: 1) Es wird unmittelbar vor der Account-Information eine Stammdaten-Änderung versandt, die das Thema PW ebenfalls triggert. (Hier ist der Reset-Link drin.) 2) Inhaltlich macht die Account-Info-Mail noch keinen Sinn, da die Abgrenzung zu den Stammdaten-Änderungen nicht scharf genug ist, um 3 Buttons am Passwort zu rechtfertigen. Sascha Immig 2023-06-02T06:45:17.804Z
added 239 commits
  • 0270b92c...8b1175d7 - 234 commits from branch develop
  • 321a960e - Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into…
  • b65a35fa - + changed new button's label according to Sascha's specification
  • eab4b823 - adapted button tooltip and modal text
  • e944d094 - adapted mail template description texts
  • b4594347 - + hide auth.login option for (MailTemplate->identifier === 'AccountInformation')
Compare with previous version
Gregor Gabriel 2023-06-23T07:10:56.733Z
added 1 commit
  • edcd8053 - fixed MailTemplateSeeder
Compare with previous version
Gregor Gabriel 2023-06-23T07:17:43.035Z
added 25 commits
  • edcd8053...cd6d0d31 - 24 commits from branch develop
  • 3ce8ecb8 - Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into…
Compare with previous version
Gregor Gabriel 2023-06-26T06:17:25.361Z
added 1 commit
  • 869c59ed - added suspension of mailing the password change to the account resend feature
Compare with previous version
Sascha Immig 2023-06-28T18:45:44.519Z
added 1 commit
  • 9adffb82 - removed the old call of the MailTemplateSeeder since it was called immediately…
Compare with previous version
Sascha Immig 2023-06-28T18:53:15.338Z
doppelter Aufruf des Seeders wurde entfernt. Seeder muss nach Livegang einmal manuell ausgeführt werden. Sascha Immig 2023-06-28T18:54:24.496Z
resolved all discussions Sascha Immig 2023-06-28T19:04:58.892Z
merged Sascha Immig 2023-06-28T19:05:05.337Z
mentioned in commit a3edc82316d9b04929a3bf97a9e98a8bbc67ea4f Sascha Immig 2023-06-28T19:05:05.595Z

Merge Commits

Title Id Author Created at Message
AccountInformation notification uses now an editabel mail template 0270b92c577912f55ebf168c0a7e6173e0a86d71 TUV\gabrielg 2023-05-25T14:28:03.000Z AccountInformation notification uses now an editabel mail template
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into… 321a960e4418721e91dd17e4967986e867801fc2 TUV\gabrielg 2023-06-22T13:26:37.000Z Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/LL-1498-base-account-information-notification-on-mail-template # Conflicts: # database/seeders/MailTemplateSeeder.php
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into… 3ce8ecb8322c40d4324282bab81112ac5e678876 TUV\gabrielg 2023-06-26T06:17:15.000Z Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/LL-1498-base-account-information-notification-on-mail-template
added suspension of mailing the password change to the account resend feature 869c59ed0e02d7b126906cd251614f4eb7ebb913 TUV\immigs 2023-06-28T18:45:37.000Z added suspension of mailing the password change to the account resend feature
removed the old call of the MailTemplateSeeder since it was called immediately… 9adffb8267fa707d3a4398a819e20ab181312bd0 TUV\immigs 2023-06-28T18:53:06.000Z removed the old call of the MailTemplateSeeder since it was called immediately before the remaining after merge
+ hide auth.login option for (MailTemplate->identifier === 'AccountInformation') b4594347809c5ee4568ce46847e641eed04872bd TUV\gabrielg 2023-06-23T07:10:45.000Z + hide auth.login option for (MailTemplate->identifier === 'AccountInformation') + added code to supress UserCoreDataChanged notification only as comment, as the necessary method is not available yet
+ changed new button's label according to Sascha's specification b65a35fa29a219a56efc9cebe8d44efb4a86dc81 TUV\gabrielg 2023-06-22T13:42:43.000Z + changed new button's label according to Sascha's specification + do not shoe button, if user has an email entry or if user has no shared_mailbox entry
added AcountInformation notification and use it instead of AcountCreated… d3799e68fac9f2c2b73452f8a260419766f585fd TUV\gabrielg 2023-05-04T12:39:37.000Z added AcountInformation notification and use it instead of AcountCreated notification, when sending account data to user
changed code due to requirements e0a44b9f3bb5142746aa2c52d06302d2aa3bb0e5 TUV\gabrielg 2023-05-05T06:31:38.000Z changed code due to requirements
adapted mail template description texts e944d0945b41e65d6628402cfe93713c6d4e2031 TUV\gabrielg 2023-06-22T14:32:19.000Z adapted mail template description texts
adapted button tooltip and modal text eab4b823013ab82e27efdbd34f6249b0a2d33c5e TUV\gabrielg 2023-06-22T14:16:46.000Z adapted button tooltip and modal text
fixed MailTemplateSeeder edcd805383a4590a310ebb91726197d7f0dcfa80 TUV\gabrielg 2023-06-23T07:17:24.000Z fixed MailTemplateSeeder
Merge branch 'feature/LL-1467-new-acount-data-mail' of… ffc9c50ce794b7b076ab35864a75e9a76a3f35b1 TUV\gabrielg 2023-05-25T11:41:15.000Z Merge branch 'feature/LL-1467-new-acount-data-mail' of https://gitlab.learningsystem.de/lms/seventeen into feature/LL-1498-base-account-information-notification-on-mail-template * 'feature/LL-1467-new-acount-data-mail' of https://gitlab.learningsystem.de/lms/seventeen: changed code due to requirements added AcountInformation notification and use it instead of AcountCreated notification, when sending account data to user # Conflicts: # app/Notifications/MyCompetenceTrainingsAssigned.php