Details des Tickets
Beschreibung,Kommentare und Anhänge
| assigned to @gabrielg |
Sascha Immig |
2023-01-16T13:49:50.292Z |
| "select_client" und sollte eher allgemein (base.php) statt rollen-spezifisch sein. |
Sascha Immig |
2023-01-16T13:53:34.309Z |
| Die Funktion verstehe ich nicht.
Sollte der Scope `BelongsToCurrentOrNoneClientScope` nicht alle Rollen mit dem gleichen Client-Kontext oder ohne Kontext liefern? Und schaltet das `withoutGlobalScope`diese Kontext-Zuordnung nicht ab, was beim Aufruf in `show()` eher kontraproduktiv ist?
Zudem ist `full()` kein aussagekräftiger Name für die Funktion... |
Sascha Immig |
2023-01-16T13:55:48.687Z |
| Ja, der Scope `BelongsToCurrentOrNoneClientScope` ist hier noch so implementiert,
dass letztlich None-Client-User Objekte mit client-ID nicht sehen.
Das machte zwar Sinn bei der damaligen Nutzung des Scopes, war aber nicht sauber,
da der Scope das eigentlich zulassen sollte.
Das ist mir auch vor die Füße gefallen letzt bei den Tickets, wo Contents und Kategorien einen optionalen Client-Kontext bekommen haben.
Dort habe ich den Scope angepaßt, so dass er tut was man von ihm erwartet, wenn man im Model ein Flag setzt. |
Gregor Gabriel |
2023-01-17T08:28:21.983Z |
| changed this line in version 2 of the diff |
Gregor Gabriel |
2023-01-17T09:50:23.558Z |
added 70 commits
- 507fc5cd...82725779 - 68 commits from branch
develop - 30c9b1a6 - Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into…
- 2dcbf57d - changed way how we restrict access to roles
Compare with previous version |
Gregor Gabriel |
2023-01-17T09:50:23.752Z |
| changed this line in version 3 of the diff |
Sascha Immig |
2023-01-17T11:57:31.016Z |
| resolved all discussions |
Sascha Immig |
2023-01-17T11:57:31.193Z |
added 1 commit
- 58a31f6e - changed translation from 'choose' to 'select' (choose: to have a preference for…
Compare with previous version |
Sascha Immig |
2023-01-17T11:57:32.277Z |
| merged |
Gregor Gabriel |
2023-01-17T13:29:22.587Z |
| mentioned in commit 048049aa14fb4b847421cb96148baf979a643935 |
Gregor Gabriel |
2023-01-17T13:29:22.959Z |
| Title |
Id |
Author |
Created at |
Message |
| changed way how we restrict access to roles |
2dcbf57dcc6c212a6980e8e4011d76d73d95f432 |
TUV\gabrielg |
2023-01-17T09:50:16.000Z |
changed way how we restrict access to roles
|
| Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into… |
30c9b1a6059f79501f140499b77286004b6c66bd |
TUV\gabrielg |
2023-01-17T09:34:11.000Z |
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/LL-1333-clients-roles-do-not-work-for-super-admins
# Conflicts:
# resources/views/admin/roles/table.blade.php
|
| Delete roles button is shown only if there are no users in it, remove deleted_at… |
507fc5cd9942c4774a6cf63fb179c39d03c36ea0 |
gerlachm |
2023-01-13T10:32:05.000Z |
Delete roles button is shown only if there are no users in it, remove deleted_at column in RoleRequest
|
| Discard the addition of soft deletes |
54b44580a728800965947d7883d3c0f6c8c06693 |
gerlachm |
2023-01-13T07:18:48.000Z |
Discard the addition of soft deletes
|
| changed translation from 'choose' to 'select' (choose: to have a preference for… |
58a31f6ec6f12c87ddf911b6a527b6dd2b4ec1b5 |
TUV\immigs |
2023-01-17T11:57:17.000Z |
changed translation from 'choose' to 'select' (choose: to have a preference for or to select freely / select: to choose from a number or group). Moved key from role to base, since it can appear in several occasions.
|
| LL-1333-clients-roles-do-not-work-for-super-admins |
7c886dfe2cd6e22d8eab77186ab88101db3364d9 |
gerlachm |
2023-01-12T14:12:35.000Z |
LL-1333-clients-roles-do-not-work-for-super-admins
Added role dropdown for superadmins when creating and editing, extended table overview, unique clients, added softDeletes
|