Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 718
TitelLL-1301: Refactoring of Content and ContentBlock / ContentBlockPosition models
Beschreibung
Statusmerged
Created at 2022-12-14T10:18:30.421Z
Updated at 2022-12-20T13:54:24.218Z
Source branchfeature/LL-1301--content-and-contentblocks
Target branchdevelop
AuthorSascha Immig
AssigneeGregor Gabriel

Discussion notes

added 1 commit
  • 14bd39e8 - Changed return type form string to ?string since tests failed. Added todo…
Compare with previous version
Sascha Immig 2022-12-15T08:59:00.608Z
added 1 commit
  • b0542b52 - CS Fixer
Compare with previous version
Sascha Immig 2022-12-16T09:59:48.785Z
added 1 commit
  • af636b6b - fixed passing of this->id to a helper that is accepting only string. Added TODO…
Compare with previous version
Sascha Immig 2022-12-16T10:52:45.748Z
warum heißt das nicht `protected array $casts = [ ...` Gregor Gabriel 2022-12-20T12:21:19.890Z
resolved all discussions Sascha Immig 2022-12-20T13:54:14.570Z
resolved all discussions Gregor Gabriel 2022-12-20T13:54:18.274Z
merged Gregor Gabriel 2022-12-20T13:54:24.359Z
mentioned in commit 28905bd313f4caa1d729cfda69219c59e130903c Gregor Gabriel 2022-12-20T13:54:24.625Z

Merge Commits

Title Id Author Created at Message
Changed return type form string to ?string since tests failed. Added todo… 14bd39e86832a8d270e0700cb3bad2510e45001d TUV\immigs 2022-12-15T08:58:45.000Z Changed return type form string to ?string since tests failed. Added todo comment, because it should be string. also optimized if statement.
Refactoring of Content and ContentBlock / ContentBlockPosition models a5505329125c760f32ca0563ccdca35d41777b70 TUV\immigs 2022-12-14T10:16:09.000Z Refactoring of Content and ContentBlock / ContentBlockPosition models
fixed passing of this->id to a helper that is accepting only string. Added TODO… af636b6bc02fd77beb3af2aa43f1e3c975b10b0b TUV\immigs 2022-12-16T10:52:38.000Z fixed passing of this->id to a helper that is accepting only string. Added TODO comment regarding futher investigation.
CS Fixer b0542b52e475f3b839715e18fcc4c945c5b8c6a3 TUV\immigs 2022-12-16T09:59:38.000Z CS Fixer