Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 695
TitelLL-1289 if the login contains an e-mail, it is now also checked whether this is…
BeschreibungLL-1289 if the login contains an e-mail, it is now also checked whether this is stored in the system. If no, username is used for login
Statusmerged
Created at 2022-11-10T08:08:07.030Z
Updated at 2023-09-22T10:15:07.885Z
Source branchfeature/LL-1289-customer_login_should_accept_username_with_at_sign
Target branchdevelop
AuthorMarkus Gerlach
AssigneeSascha Immig

Discussion notes

und was, wenn der User mit dieser Mail zu einem anderen Client gehört? wir müssen schon zwingend im Client-Kontext bleiben. @all: Ist es evtl. besser, weiter unten beim `auth()->attempt($credentials)` ggf. einen 2. Versuch auf `username` zu machen, wenn `email` fehlschlägt? Sascha Immig 2022-11-10T16:27:45.545Z
changed this line in version 2 of the diff Markus Gerlach 2022-11-11T07:36:58.760Z
resolved all discussions Markus Gerlach 2022-11-11T07:36:59.117Z
added 1 commit
  • 20b333fc - LL-1289 extended filter for user search
Compare with previous version
Markus Gerlach 2022-11-11T07:36:59.316Z
Ja das macht Sinn habe die Filter erweitert Markus Gerlach 2022-11-11T07:38:37.321Z
added 1553 commits
  • 20b333fc...514d128b - 1550 commits from branch develop
  • 3221969e - make sure username cannot be an email that is already used in actual client
  • ea875903 - Revert "make sure username cannot be an email that is already used in actual client"
  • 390ed44a - Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into…
Compare with previous version
Gregor Gabriel 2023-07-14T10:20:24.470Z
added 1 commit
  • 3ce17642 - added update rules to API
Compare with previous version
Gregor Gabriel 2023-07-14T11:10:25.663Z
added 1 commit
  • abb24def - + user import now uses CreateUserRequest and UpdateUserRequest to validate…
Compare with previous version
Gregor Gabriel 2023-07-17T15:59:16.944Z
added 1 commit
  • a99c0e1e - renamed keys for clarity and as confirmed with Sascha
Compare with previous version
Gregor Gabriel 2023-07-19T07:49:16.289Z
added 89 commits
  • a99c0e1e...eaf48b75 - 88 commits from branch develop
  • 11a199a3 - Merge branch 'develop' into feature/LL-1289-customer_login_should_accept_username_with_at_sign
Compare with previous version
Richard Klings 2023-08-01T08:48:09.892Z
added 1 commit
  • ded20276 - LL-1289: Tests auf den username/email Check angepasst, Der Test auf die…
Compare with previous version
Richard Klings 2023-08-14T12:14:31.090Z
added 1 commit
  • d46c377b - little code optimization suggested by IDE
Compare with previous version
Gregor Gabriel 2023-08-23T07:41:24.943Z
added 1 commit
  • 03474e45 - + use chunk in user export to reduce memory usage
Compare with previous version
Gregor Gabriel 2023-08-23T09:48:04.737Z
merged Sascha Immig 2023-09-22T10:15:07.937Z

Merge Commits

Title Id Author Created at Message
+ use chunk in user export to reduce memory usage 03474e4573eb2d9b2abcba36969eba065d273153 TUV\gabrielg 2023-08-23T09:47:56.000Z + use chunk in user export to reduce memory usage + optimized code style + checked that export of all users of "Deutsches Jugendherbergswerk Hauptverband e. V." can be reimported
Merge branch 'develop' into feature/LL-1289-customer_login_should_accept_username_with_at_sign 11a199a3a9cf0e6bb674c8f7da706dd0f580d8fa Richard Klings 2023-08-01T08:47:23.000Z Merge branch 'develop' into feature/LL-1289-customer_login_should_accept_username_with_at_sign
LL-1289 extended filter for user search 20b333fcfbbfb574d16f9436d5629a978c950aa8 gerlachm 2022-11-11T07:36:55.000Z LL-1289 extended filter for user search
make sure username cannot be an email that is already used in actual client 3221969e268db929b7733ebf9e0e12768e8a76be TUV\gabrielg 2023-07-14T09:40:26.000Z make sure username cannot be an email that is already used in actual client
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into… 390ed44a73694654f4c4a821e5ae4237d9e96444 TUV\gabrielg 2023-07-14T10:20:17.000Z Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/LL-1289-customer_login_should_accept_username_with_at_sign extended user validators: + added rules o make sure a new/existing client-users email is not a username of another user in the client scope + added rules o make sure a new/existung client-users username is not an email of another user in the client scope
added update rules to API 3ce176429a26fe110c0d39fd37c502bd04817541 TUV\gabrielg 2023-07-14T11:10:22.000Z added update rules to API
renamed keys for clarity and as confirmed with Sascha a99c0e1e26bc28ad8cd7ec87dd19781a2b0a50f0 TUV\gabrielg 2023-07-19T07:49:08.000Z renamed keys for clarity and as confirmed with Sascha
+ user import now uses CreateUserRequest and UpdateUserRequest to validate… abb24def4d1b97eb04f59e3700d1875f17525a05 TUV\gabrielg 2023-07-17T15:59:08.000Z + user import now uses CreateUserRequest and UpdateUserRequest to validate import data bevore creating or updating user + encapsulated import-cache specific data access to UserImport class
LL-1289 if the login contains an e-mail, it is now also checked whether this is… cc9a9d4ad12050ed9f90a63294060f07839613a1 gerlachm 2022-11-10T07:17:17.000Z LL-1289 if the login contains an e-mail, it is now also checked whether this is stored in the system. If no, username is used for login
little code optimization suggested by IDE d46c377b7627812be9a9eb320caf09f8036253b3 TUV\gabrielg 2023-08-23T07:41:15.000Z little code optimization suggested by IDE
LL-1289: Tests auf den username/email Check angepasst, Der Test auf die… ded20276770ca651485b24e4e61fc2471630affe Richard Klings 2023-08-14T12:14:17.000Z LL-1289: Tests auf den username/email Check angepasst, Der Test auf die Maximalzahl funktionierte nicht, Anpassung, der Fehlermeldunge, dass die Tests auf eine Fehlernummer testen, Warnings beseitigt Tests kommentiert
Revert "make sure username cannot be an email that is already used in actual client" ea875903e0776a37a2454ad25623796057e97e85 TUV\gabrielg 2023-07-14T09:47:50.000Z Revert "make sure username cannot be an email that is already used in actual client" This reverts commit 3221969e268db929b7733ebf9e0e12768e8a76be.