Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 691
TitelFeature/ll 1246 update registration
BeschreibungBitte Unteraufgaben testen. Diese sind der Einfachheit halber ein Branch.
Statusmerged
Created at 2022-11-02T15:01:30.999Z
Updated at 2022-11-08T07:22:44.885Z
Source branchfeature/LL-1246--update-registration
Target branchdevelop
AuthorSascha Immig
AssigneeGregor Gabriel

Discussion notes

assigned to @gabrielg Sascha Immig 2022-11-03T07:32:00.117Z
added 1 commit
  • 74d6c5be - + fixed proxy support for vat id validator service
Compare with previous version
Gregor Gabriel 2022-11-04T12:50:06.620Z
Habe alles ausgefüllt und als Ergebnis (ohne Anzeige) lieferte der Request eine 422 {"message":"The given data was invalid.","errors":{"tariff":["tariff ist erforderlich."]}} zurück. gesendet wurde: {"firstname":"Gregor","lastname":"Gabriel","companyName":"Bingo-Bongo AG","slug":"bingo-bongo-ag","companyZipCode":"80809","companyCity":"München","companyStreet":"Mossacher Str.","companyHouseNumber":"45a","customerContactPhone":"+49 89 4711 - 012","companyCountry":"DE","companyVatId":"DE327006907","email":"gregor.christian.gabriel@de.tuv.com","password":"Muc81241$$","differentBillAddress":true,"billAddressCompanyName":"Bingo-Bongo AG","billAddressZipCode":"80809","billAddressCity":"München","billAddressStreet":"Mossacher Str.","billAddressHouseNumber":"45b","billAddressAdditionalAddress":"Buchhaltung","billAddressCountry":"DE","selectedtariff":"basic","max_allowed_users":25,"payment_interval":"yearly"} Habe die zugehörige Vue Komponente angepasst, dass sie auch noch den Parameter "tariff" mitsendet Gregor Gabriel 2022-11-04T13:11:41.036Z
added 1 commit
  • 8b54f1ba - added parameter tariff to registration request to avoid validation error
Compare with previous version
Gregor Gabriel 2022-11-04T13:12:46.880Z
nach der Registrierung für Professional 25 wird mir folgendes angezeigt: Monatlicher Preis (---129 €---) 116,1 € wobei 116,1 € komisch aussieht. Wäre 116,10 € nicht besser? Selbiges gilt für die Anzeige der Gesamtsumme Gregor Gabriel 2022-11-04T13:16:29.625Z
added 1 commit
  • 7fe100cd - fixed js error in vue component
Compare with previous version
Gregor Gabriel 2022-11-04T14:02:44.236Z
Ich hatte keine Telefonnummer angegeben und folgenden 500er bekommen: [2022-11-04 13:47:37] local.ERROR: Undefined index: customerContactPhone {"exception":"[object] (ErrorException(code: 0): Undefined index: customerContactPhone at /home/vagrant/code/app/Http/Controllers/Auth/RegisterController.php:217) Hab's im Code korrigiert Gregor Gabriel 2022-11-04T14:04:02.731Z
Generell funktioniert jetzt alles - Die Anzeige der Preise ist aber suboptimal Gregor Gabriel 2022-11-04T14:04:52.318Z
added 2 commits
  • a908129c - removed wrong post data
  • be9edefb - formatted amounts
Compare with previous version
Sascha Immig 2022-11-07T09:21:10.949Z
merged Sascha Immig 2022-11-08T07:22:44.927Z

Merge Commits

Title Id Author Created at Message
LL-1281: pre-fill billing company name with company name, when not set before.… 064e18f75b3cebd0acb66839d82a27b0180edae4 TUV\immigs 2022-10-31T15:35:26.000Z LL-1281: pre-fill billing company name with company name, when not set before. (not bullet-proof when reloading in the middle of the process occurs)
added changeable prefix to the trans mixin. 0bc9001c6329646a4efb08250d793e5588fe0584 TUV\immigs 2022-11-02T14:43:04.000Z added changeable prefix to the trans mixin. For now no replacements are used, so this works fine. If a translation need replacements, the prefix must be set. After the refactoring of the language files, the keys are no longer complete texts. then the prefix should be part of the given key.
divided template into several ssub templates for better readability. Switched to material tabs. 2454319a4aff6a13363b555cb9deeb2ce5074552 TUV\immigs 2022-10-27T10:53:30.000Z divided template into several ssub templates for better readability. Switched to material tabs.
some optimization for mobile / not enough space. 56667eafa169dcfc60cedd8bc7f931d8e9d4a058 TUV\immigs 2022-10-27T10:54:10.000Z some optimization for mobile / not enough space.
LL-1282: updates confirmation page. 56fe32f76407246d92b727382d06fb9c9a11b18c TUV\immigs 2022-10-28T12:40:34.000Z LL-1282: updates confirmation page. - replaed icon with brand icon style - optimized texts - optimized mobile view - added more white space
added base URL to slug on check page 6fb8df018e4c37c9814525473d7801ea3633853b TUV\immigs 2022-10-31T14:57:00.000Z added base URL to slug on check page
+ fixed proxy support for vat id validator service 74d6c5be5ee7f98fc2c5a708b2f1a38fddb7d35c TUV\gabrielg 2022-11-04T12:49:59.000Z + fixed proxy support for vat id validator service
removed warning csince prop and data for tariff had the same name. 76e763d96bab27feae352d84d8cb917c335d8302 TUV\immigs 2022-10-31T11:51:12.000Z removed warning csince prop and data for tariff had the same name. Also: code cosmetics.
fixed js error in vue component 7fe100cda50ca358aefcc737a54d5019b0ea68ea TUV\gabrielg 2022-11-04T14:02:39.000Z fixed js error in vue component fixed php error in registration controller
added parameter tariff to registration request to avoid validation error 8b54f1baa5e71c801a7e1b607eaf5a8a03630a45 TUV\gabrielg 2022-11-04T13:12:41.000Z added parameter tariff to registration request to avoid validation error
removed wrong post data a908129c1b5521da27b908d9a6f98cbe618f7933 TUV\immigs 2022-11-07T08:41:49.000Z removed wrong post data
formatted amounts be9edefb8b311077c322557fe5d28b27926c6724 TUV\immigs 2022-11-07T09:21:02.000Z formatted amounts
braking down slug generation into separate methords for a clearer code and reuse… d21d0ddbeeb927388cab7c5e03bcb21596f7fab1 TUV\immigs 2022-10-31T14:56:34.000Z braking down slug generation into separate methords for a clearer code and reuse at different points of the code
refactoring the form e9a4c02e42ff0f9c3adead6cdf985c5c0360cd21 TUV\immigs 2022-10-28T13:41:24.000Z refactoring the form
added function to get the full country name from abbreviation. fcf8a539676598a0de1ebfce67ae1cea2b346de2 TUV\immigs 2022-10-31T12:01:39.000Z added function to get the full country name from abbreviation.