Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 620
TitelFeature/ll 1179 automatic removal of deleted users
Beschreibungs. http://jira.learningsystem.de/browse/LL-1179
Statusmerged
Created at 2022-05-11T13:44:49.521Z
Updated at 2022-05-20T19:07:53.311Z
Source branchfeature/LL-1179-automatic-removal-of-deleted-users
Target branchdevelop
AuthorGregor Gabriel
AssigneeSascha Immig

Discussion notes

added 1 commit
  • 315fc13c - added missing or changed existing foreign key constraints for references to users table
Compare with previous version
Gregor Gabriel 2022-05-12T15:33:46.938Z
added 1 commit
  • 5dd4094d - use factories instead of constructors in api tests
Compare with previous version
Gregor Gabriel 2022-05-13T06:58:32.748Z
added 1 commit
  • 025bb6e0 - + optimized API test code, so that clean test clients come without any user
Compare with previous version
Gregor Gabriel 2022-05-13T07:40:34.651Z
als Reminder: contact-person darf nicht gelöscht werden. Muss erst manuell gelöst werden. Sascha Immig 2022-05-19T06:18:14.103Z
Support Employee kann nur ein TRA-MA sein. Auch hier muss manuell erst ein neuer MA den Mandanten zugewiesen werden. Sascha Immig 2022-05-19T06:19:00.987Z
Sind Orders aktiv oder Überrest aus MYC? Sascha Immig 2022-05-19T06:20:08.015Z
wie oben: nur für Admins. Sascha Immig 2022-05-19T06:23:16.451Z
Campaign - wie Voucher - betrifft nur Admins bzw. TRA-MA. dgl. gilt für Trainings und DistributionPartner. Ich bin mir nicht sicher, ob wir hier den Default-User brauchen oder besser für null sorgen. Auf jeden Fall die 6 Zeilen bitte Gruppieren mit Kommentar, dass das für Admins ist. Sascha Immig 2022-05-19T06:23:35.711Z
betrifft nur Admins. s.u. Sascha Immig 2022-05-19T06:23:45.657Z
betrifft auch nur Admins. Würde ich zum obigen Block der Admin-Features hinzufügen (reine Code-Struktur). Ist es Sinnvoll, die ganzen Funktionen für Admins in ein if zu verpacken? Sascha Immig 2022-05-19T06:26:14.399Z
Orders sind die Objekte die mehrere Training-Assignments zu einem Buchungsvorgang zusammenfasst. Sie sind also aktiv. Gregor Gabriel 2022-05-20T11:41:13.673Z
changed this line in version 5 of the diff Gregor Gabriel 2022-05-20T12:02:29.149Z
added 1 commit
  • 3d0183ce - + added more documentation
Compare with previous version
Gregor Gabriel 2022-05-20T12:02:29.299Z
changed this line in version 6 of the diff Sascha Immig 2022-05-20T13:58:08.823Z
changed this line in version 6 of the diff Sascha Immig 2022-05-20T13:58:09.130Z
changed this line in version 6 of the diff Sascha Immig 2022-05-20T13:58:09.368Z
added 1 commit
  • c5b81b77 - code structure
Compare with previous version
Sascha Immig 2022-05-20T13:58:09.529Z
added 1 commit
  • 4de22d10 - codeStyle
Compare with previous version
Sascha Immig 2022-05-20T14:26:00.449Z
resolved all discussions Sascha Immig 2022-05-20T19:07:46.948Z
merged Sascha Immig 2022-05-20T19:07:53.384Z
mentioned in commit f05f2d735542d7518b93da71ff1eda0c03679f77 Sascha Immig 2022-05-20T19:07:53.657Z

Merge Commits

Title Id Author Created at Message
+ went throug all tables and looked for relations to users table and handled that relations 0162f20581d7e7fce40c50f7d252b306e4f4aaee TUV\gabrielg 2022-05-11T12:59:39.000Z + went throug all tables and looked for relations to users table and handled that relations
+ optimized API test code, so that clean test clients come without any user 025bb6e04e224857a17cf68f33b91b3b590f1669 TUV\gabrielg 2022-05-13T07:27:09.000Z + optimized API test code, so that clean test clients come without any user
added missing or changed existing foreign key constraints for references to users table 315fc13cf133583cf017c648911423e792355cc0 TUV\gabrielg 2022-05-12T15:33:40.000Z added missing or changed existing foreign key constraints for references to users table
+ added more documentation 3d0183ced0f5b0be75caa3739ac0b2c5702336ab TUV\gabrielg 2022-05-20T12:02:20.000Z + added more documentation + reorganized code, into a block only for admins and a second one for ordinary employees
codeStyle 4de22d105f8b85fb597e69cfeac3a4a83b168a3c TUV\immigs 2022-05-20T14:25:46.000Z codeStyle
use factories instead of constructors in api tests 5dd4094d5e1a6a47c05b1c506ea9f93c30bb84ec TUV\gabrielg 2022-05-13T06:58:24.000Z use factories instead of constructors in api tests
+ added tests for puning a user 8e06ae3ad3701afc23533468c2a76035b68817b9 TUV\gabrielg 2022-05-11T10:53:04.000Z + added tests for puning a user + adapted existing code, so that it is capable of accessing deleted users
code structure c5b81b77430fe274cee9baa19f687bb7b442d4df TUV\immigs 2022-05-20T13:58:00.000Z code structure
+ first implementation of pruning deleted users from database after one month of being deleted e4c22fb55277f3e5c320123bc0a57177311ee425 TUV\gabrielg 2022-05-11T07:20:51.000Z + first implementation of pruning deleted users from database after one month of being deleted - tests are missing