Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 574
TitelLL-1109: declare notice periods in subscriptions config
BeschreibungDie Kündigungfristen in der Subscription.php eintragen. Kündigungsfristen sind : 4 Wochen vor Ende des Quartals bzw. 3 Monate vor Aboablauf bei Jährlich Nur zu Info, Laufzeiten der Abos sind: Jährlich -> 365 Tage, kein Kalenderjahr quartalsweise -> 1. Re bis Ende des Quartals (anteilig), dann Quartalsweise (Kalenderjahr synchronisiert)
Statusmerged
Created at 2022-02-24T09:41:26.913Z
Updated at 2022-03-11T13:50:23.605Z
Source branchfeature/LL-1109-declare-notice-periods-in-subscriptions-config
Target branchdevelop
AuthorGregor Gabriel
AssigneeSascha Immig

Discussion notes

added 1 commit
  • bbdcd80f - added possibility to get netxt_notice_period_end_at for subscriptions
Compare with previous version
Gregor Gabriel 2022-02-24T14:02:19.968Z
added 7 commits
  • bbdcd80f...8612b611 - 5 commits from branch develop
  • 14adff86 - wip - code should correctly handle voucher expiration, but needs code from LL-1109
  • c2e6f012 - Merge branch 'feature/LL-1045-handle-voucher-expiry' into…
Compare with previous version
Gregor Gabriel 2022-02-24T16:40:23.190Z
marked as a **Work In Progress** from 14adff86f8907a54bcd3932515210c3b24cc61cd Gregor Gabriel 2022-02-24T16:40:23.460Z
unmarked as a **Work In Progress** Sascha Immig 2022-03-07T08:35:32.295Z
changed title from **{-WIP: Feature/ll 1109-} declare notice periods in subscriptions config** to **{+LL-1109:+} declare notice periods in subscriptions config** Sascha Immig 2022-03-07T08:35:32.320Z
changed the description Sascha Immig 2022-03-07T08:35:32.355Z
müsste doch `invalid subscriptions.payment_interval` bleiben... findet switch() keinen gültigen Intervall kommt default ins Spiel. Sascha Immig 2022-03-07T13:32:17.165Z
Absicht, dass hier `Carbon::` fehlt? Sascha Immig 2022-03-07T13:32:42.211Z
Grund für SubDays(4) bitte kurz als Kommentar Sascha Immig 2022-03-07T13:45:21.286Z
`now()` ist eine Akürzung für `Carbon::now()`. Es ist nicht nur kürzer, aber man muss dafür nicht mal `use Carbon\Carbon;` deklarieren Gregor Gabriel 2022-03-08T07:44:18.757Z
added 1 commit
  • 1b423e36 - + adapted exception message to be more expressive
Compare with previous version
Gregor Gabriel 2022-03-08T08:35:20.775Z
Habe den Exception Text angepasst Gregor Gabriel 2022-03-08T08:36:08.161Z
Kommentar ist hinzugefügt Gregor Gabriel 2022-03-08T08:37:02.547Z
resolved all discussions Gregor Gabriel 2022-03-08T08:37:03.529Z
resolved all discussions Gregor Gabriel 2022-03-08T08:49:17.636Z
added 1 commit
  • d4788930 - + removed refererence to to notice_period from exception text
Compare with previous version
Gregor Gabriel 2022-03-08T08:49:17.902Z
enabled an automatic merge when the pipeline for d4788930a89a083a3bf2ee88d778a10ba024b363 succeeds Sascha Immig 2022-03-08T08:52:14.005Z
merged Sascha Immig 2022-03-08T08:57:43.804Z
mentioned in commit 8491e86436f56786fe2fefb4411a591caf71d06a Sascha Immig 2022-03-08T08:57:43.996Z
Enthält auch 'LL-1045 Sascha Immig 2022-03-11T13:50:23.593Z

Merge Commits

Title Id Author Created at Message
wip - code should correctly handle voucher expiration, but needs code from LL-1109 14adff86f8907a54bcd3932515210c3b24cc61cd TUV\gabrielg 2022-02-24T12:52:42.000Z wip - code should correctly handle voucher expiration, but needs code from LL-1109
+ adapted exception message to be more expressive 1b423e36acb685e96606c9dda4ac8b0677eb8382 TUV\gabrielg 2022-03-08T08:34:45.000Z + adapted exception message to be more expressive + added comment to clarify code sequence
take data to count end of payment interval from config/subscriptions.php 5cc1d61529df3fb302cd9b961426306c19f0b74d TUV\gabrielg 2022-02-23T16:54:01.000Z take data to count end of payment interval from config/subscriptions.php
added test for dubscriptions next_possible_end calculation 6614e21fcc984ee8dcfd19f85ea87f80db78678e TUV\gabrielg 2022-02-24T09:38:18.000Z added test for dubscriptions next_possible_end calculation
added possibility to get netxt_notice_period_end_at for subscriptions bbdcd80f9955eaad65de87c8115acd60c6c2aa6b TUV\gabrielg 2022-02-24T14:01:52.000Z added possibility to get netxt_notice_period_end_at for subscriptions
Merge branch 'feature/LL-1045-handle-voucher-expiry' into… c2e6f012de0be64fa9c0984bce8c386701322f55 TUV\gabrielg 2022-02-24T16:40:01.000Z Merge branch 'feature/LL-1045-handle-voucher-expiry' into feature/LL-1109-declare-notice-periods-in-subscriptions-config
+ removed refererence to to notice_period from exception text d4788930a89a083a3bf2ee88d778a10ba024b363 TUV\gabrielg 2022-03-08T08:48:58.000Z + removed refererence to to notice_period from exception text