merge request id	534
Titel	as model scopes are now available in repositories i removed duplikate scope…
Beschreibung	as model scopes are now available in repositories i removed duplikate scope implementtion in UserRepository
Status	merged
Created at	2021-12-02T08:00:17.849Z
Updated at	2022-01-07T15:20:49.087Z
Source branch	feature/LL-repository-improvement
Target branch	develop
Author	Gregor Gabriel
Assignee	Sascha Immig

Discussion notes

added 1 commit c33f5825 - + radically reduced number of necessary queries to display admin content list… Compare with previous version	Gregor Gabriel	2021-12-02T17:57:22.233Z
added 1 commit 1c46024d - + reduced number of queries in user administration minus 100 Compare with previous version	Gregor Gabriel	2021-12-07T11:22:08.407Z
--	Sascha Immig	2022-01-07T10:58:20.362Z
Prüfen, wo es genutzt wird: wenn es um Sichtbarkeit geht, ist das OK, wenn es um die Zuordnung geht, darf es kein Superadmin sein,	Sascha Immig	2022-01-07T11:07:42.040Z
Zeile mit dem Repository entfernt	Gregor Gabriel	2022-01-07T11:33:11.501Z
Der Scope wird an folgenden 3 Stellen verwendet: 1) UserController::search() Die Nutzung erfolgt hier über das Repository und die dortige Implementierung wurde durch die idenitsche Implementierung als Scope ersetzt (OK) 2) MyTrainingController::supervisorCategories($training) Existiert für eine Kategorie kein Supervisor, so wird nach Usern mit dem Recht gesucht. Diese stehen dann dem Template `user.trainings.show` zur Verfügung. Hier wurde vorher der alte Scope (ohne is_superadmin) genutzt. Ich sehe hier aber kein Problem. 3) Models/Training::askSupervisors($message) Hier wird, falls dem Training per Kategorie kein Supervisor zugewiesen ist, nach Usern mit dem Recht `capable_of_being_supervisor` gesucht. Auch hier wirkt sich die Änderung als Neuerung aus. Alle so identifizierten Supervisors erhalten eine notification. Ich denke, dass das so sein soll.	Gregor Gabriel	2022-01-07T11:55:42.475Z
resolved all discussions	Gregor Gabriel	2022-01-07T11:56:16.064Z
changed this line in version 4 of the diff	Gregor Gabriel	2022-01-07T11:59:36.483Z
resolved all discussions	Gregor Gabriel	2022-01-07T11:59:36.656Z
added 1 commit 74984311 - removed unnecessary code Compare with previous version	Gregor Gabriel	2022-01-07T11:59:36.810Z
resolved all discussions	Gregor Gabriel	2022-01-07T13:08:12.127Z
added 63 commits 74984311...f6c48848 - 62 commits from branch develop 1e9ecf8a - Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into… Compare with previous version	Gregor Gabriel	2022-01-07T13:08:12.675Z
changed this line in version 6 of the diff	Sascha Immig	2022-01-07T15:13:06.961Z
resolved all discussions	Sascha Immig	2022-01-07T15:13:07.034Z
added 1 commit 8b253375 - refactor: removed _is superadmin from query Compare with previous version	Sascha Immig	2022-01-07T15:13:07.205Z
enabled an automatic merge when the pipeline for 8b25337572d4cc386c9d53f8572bd7ec9715701e succeeds	Sascha Immig	2022-01-07T15:13:24.518Z
merged	Sascha Immig	2022-01-07T15:20:49.147Z
mentioned in commit 8cb12b2e22552ada965fa7ee63eeeead8c8a2f39	Sascha Immig	2022-01-07T15:20:49.337Z

Merge Commits

Title	Id	Author	Created at	Message
as model scopes are now available in repositories i removed duplikate scope…	00d4d6f2ded183e5045d479dbcd88147e05b6089	TUV\gabrielg	2021-12-02T07:56:32.000Z	as model scopes are now available in repositories i removed duplikate scope implementtion in UserRepository
+ reduced number of queries in user administration minus 100	1c46024d160f7f13a60b4cf6ee91a08546243bd0	TUV\gabrielg	2021-12-07T11:21:57.000Z	+ reduced number of queries in user administration minus 100
Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into…	1e9ecf8a9558f7eabae26c462a779c5df338bd41	TUV\gabrielg	2022-01-07T13:07:59.000Z	Merge branch 'develop' of https://gitlab.learningsystem.de/lms/seventeen into feature/LL-repository-improvement
removed unnecessary code	74984311d0e75b1f9e4f0cb2b486dc0b41f563a4	TUV\gabrielg	2022-01-07T11:59:20.000Z	removed unnecessary code
refactor: removed _is superadmin from query	8b25337572d4cc386c9d53f8572bd7ec9715701e	TUV\immigs	2022-01-07T15:12:55.000Z	refactor: removed _is superadmin from query This parts was last changed in oct 2018. It seems to be a laftover from a myc feature, since the search/supervisor route is not used anymore. Therefor the implementation from UserRepository to User was not needed.
+ radically reduced number of necessary queries to display admin content list…	c33f5825394777de38956f06c420fae78b11a8d5	TUV\gabrielg	2021-12-02T17:57:10.000Z	+ radically reduced number of necessary queries to display admin content list from about 188 queries to about 30