merge request id	377
Titel	LL-808-Adjustment-of-booking-feedback
Beschreibung
Status	merged
Created at	2021-02-18T12:00:12.645Z
Updated at	2021-03-05T07:29:39.242Z
Source branch	feature/LL-808-Adjustment-of-booking-feedback
Target branch	develop
Author	Markus Gerlach
Assignee	Sascha Immig

Discussion notes

Generell der richtige Ansatz... Am User befindet sich jedoch schon die Funktion `getDisplayNameAttribute()` und damit sollte mittels `$user->display_name` das gleiche erreicht werden, wie durch die neue Funktion im Controller. Dort ist der Fallback sogar tiefgreifender: Name > EMail > Usename > User + ID. Leider fehlt der Funktion im User die Anrede... aber vielleicht fällt uns da etwas schlaues ein...	Sascha Immig	2021-02-19T14:36:51.865Z
vielleicht mach es Sinn, am User eine zentrale Funktion zu habne, die Parameter wie `with_salutaiton` annimmt und die dann von dne get*Attribute()-Funktionen passend aufgerufen wird... dann würden name, full_name, slutated_full_name, display_name etc. sich zum einen gleich verhalten und der Code wäre aufgeräumter... Gerne kommende Woche mal mit Gregor und mir in einem kurzen Termin besprechen...	Sascha Immig	2021-02-19T14:39:28.657Z
added 1 commit af0ebabd - LL-808-Adjustment-of-booking-feedback-update Compare with previous version	Markus Gerlach	2021-02-26T09:19:06.890Z
resolved all discussions	Sascha Immig	2021-03-01T07:51:46.266Z
added 1 commit 855cc073 - LL-808-Adjustment-of-booking-feedback-update Compare with previous version	Markus Gerlach	2021-03-01T15:42:21.931Z
ok erledigt	Markus Gerlach	2021-03-01T15:51:25.285Z
added 12 commits 855cc073...bfbcdb04 - 11 commits from branch develop 7a38f58e - Merge branch 'develop' into 'feature/LL-808-Adjustment-of-booking-feedback' Compare with previous version	Sascha Immig	2021-03-01T16:52:36.579Z
added 1 commit aa42df89 - Darwin LL-808-Adjustment-of-booking-feedback-rename-migration Compare with previous version	Markus Gerlach	2021-03-02T14:29:38.510Z
added 1 commit 272502bf - LL-808-Adjustment-of-booking-feedback-rename-migration-training-reminder Compare with previous version	Markus Gerlach	2021-03-02T14:46:06.543Z
added 1 commit 6cb01192 - LL-808-Adjustment-of-booking-feedbackrename-both-migrations Compare with previous version	Markus Gerlach	2021-03-02T14:56:48.606Z
added 1 commit 6b3e8839 - removed migration errors Compare with previous version	Sascha Immig	2021-03-03T09:53:27.738Z
added 1 commit 66a27703 - fixed scripts Compare with previous version	Sascha Immig	2021-03-04T20:51:01.425Z
added 1 commit e2adb3cc - fixed rollback script Compare with previous version	Sascha Immig	2021-03-04T21:06:06.954Z
merged	Sascha Immig	2021-03-05T07:29:39.543Z
mentioned in commit d1b1869237265e2568166109737e44f15009e149	Sascha Immig	2021-03-05T07:29:40.670Z

Merge Commits

Title	Id	Author	Created at	Message
LL-808-Adjustment-of-booking-feedback-rename-migration-training-reminder	272502bf77674a29294b49c229a9ff730f2aeda7	gerlachm	2021-03-02T14:42:35.000Z	LL-808-Adjustment-of-booking-feedback-rename-migration-training-reminder
fixed scripts	66a27703a050079d200e109a135053d6027a0588	TUV\immigs	2021-03-04T20:48:24.000Z	fixed scripts
removed migration errors	6b3e8839a467276d204bf46f2f529884a329dec6	TUV\immigs	2021-03-03T09:53:06.000Z	removed migration errors
LL-808-Adjustment-of-booking-feedbackrename-both-migrations	6cb01192fc9ccc144a690834c64b47d71069c313	gerlachm	2021-03-02T14:55:24.000Z	LL-808-Adjustment-of-booking-feedbackrename-both-migrations
Merge branch 'develop' into 'feature/LL-808-Adjustment-of-booking-feedback'	7a38f58e0f90d6fdcb7898d7f41b46ee2099a236	Sascha Immig	2021-03-01T16:52:30.000Z	Merge branch 'develop' into 'feature/LL-808-Adjustment-of-booking-feedback' # Conflicts: # app/Notifications/QuestionAboutTraining.php
LL-808-Adjustment-of-booking-feedback-update	855cc0733acedeb6660ad31449e23f429f1d9ab3	gerlachm	2021-03-01T15:39:51.000Z	LL-808-Adjustment-of-booking-feedback-update
LL-808-Adjustment-of-booking-feedback	8fda67b93b170a82d6f76e2e5d870805f17fc668	gerlachm	2021-02-18T11:47:14.000Z	LL-808-Adjustment-of-booking-feedback
Darwin LL-808-Adjustment-of-booking-feedback-rename-migration	aa42df89bfd7b48d18f34efd53b183326211e671	gerlachm	2021-03-02T14:26:12.000Z	Darwin LL-808-Adjustment-of-booking-feedback-rename-migration
LL-808-Adjustment-of-booking-feedback-update	af0ebabd47223bc3409e419e7b79a7b7a3cecf0e	gerlachm	2021-02-26T09:15:47.000Z	LL-808-Adjustment-of-booking-feedback-update
fixed rollback script	e2adb3cc48d38c27dc00ae8c47a8366e1e01278c	TUV\immigs	2021-03-04T21:05:54.000Z	fixed rollback script