Details des Tickets

Beschreibung,Kommentare und Anhänge

merge request id 352
TitelFeature/ll refactor training progress component
Beschreibung
Statusmerged
Created at 2021-01-11T16:35:36.488Z
Updated at 2021-01-14T09:08:13.098Z
Source branchfeature/LL-refactor-training-progress-component
Target branchdevelop
AuthorGregor Gabriel
AssigneeSascha Immig

Discussion notes

added 1 commit
  • ba266910 - + quickbuttons now are reactive
Compare with previous version
Gregor Gabriel 2021-01-12T11:26:12.033Z
Wenn ich nicht irre, müsste `v-if` statt `v-show` das entpsrechende Element komplett aus dme DOM entfernen, statt es nur auszublenden. https://vuejs.org/v2/guide/conditional.html >>> The difference is that an element with v-show will always be rendered and remain in the DOM; v-show only toggles the display CSS property of the element. v-if is “real” conditional rendering because it ensures that event listeners and child components inside the conditional block are properly destroyed and re-created during toggles. >>> Sascha Immig 2021-01-13T15:28:08.303Z
changed this line in version 3 of the diff Gregor Gabriel 2021-01-14T07:23:56.647Z
resolved all discussions Gregor Gabriel 2021-01-14T07:23:56.730Z
added 1 commit
  • 6c5e1044 - replaced v-show by v-if
Compare with previous version
Gregor Gabriel 2021-01-14T07:23:56.871Z
ist jetzt so umgesetzt Gregor Gabriel 2021-01-14T07:25:45.395Z
closed Gregor Gabriel 2021-01-14T07:25:45.722Z
reopened Sascha Immig 2021-01-14T09:07:17.692Z
merged Sascha Immig 2021-01-14T09:08:13.143Z
mentioned in commit 413dfd78f7c2a58ed571c52ace95f5cc80dc90fb Sascha Immig 2021-01-14T09:08:13.269Z

Merge Commits

Title Id Author Created at Message
+ provided vue component TrainingProgress 09d69d5fdb8e635b8fc41b730fac3f473b867c24 TUV\gabrielg 2021-01-11T16:11:13.000Z + provided vue component TrainingProgress + removed mixin TrainingProgress + removed vue component CircularTrainingContent and replaced it by TrainingProgress
replaced v-show by v-if 6c5e1044a1345d815efe32111aff01fc7c53645f TUV\gabrielg 2021-01-14T07:23:51.000Z replaced v-show by v-if
+ provided dump vue component ProgressBar 834439c78b45abd0e5ff3b74814f272f4f364e73 TUV\gabrielg 2021-01-08T15:38:19.000Z + provided dump vue component ProgressBar + provided dump vue component ProgressCircle + provided dump vue component ProgressUi that rendes a ProgressBar or a ProgressCircle depending on given type + refactored statefull vue component TrainingItemProgress to correctly update after UCP was closed + removed usage of vue component TrainingProgress as it was missused
replaced circular-training-progress by progress-ui in unsers training list b3fd94c75747abb5af555889615c1c5ec29b5731 TUV\gabrielg 2021-01-11T14:00:48.000Z replaced circular-training-progress by progress-ui in unsers training list
+ quickbuttons now are reactive ba266910f8340233f5f69e19b3f7c14104b85704 TUV\gabrielg 2021-01-12T11:26:06.000Z + quickbuttons now are reactive
fixed client-side progress calculation to same calculation as on server d6c4eddc3dcd406cd74f0cfdebd3bd5ed730fab5 TUV\gabrielg 2021-01-11T11:56:08.000Z fixed client-side progress calculation to same calculation as on server